Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17742
Thanks for doing this! The logic looks reasonable to me.
One comment: I'm not a fan of custom BLAS implementations scattered
throughout MLlib. I'm OK if people want to merge this now, but could you
please follow up by putting the dot as a private API in BLAS.scala and adding
unit tests?
@mpjlu You can remove the "[ML]" tag from the PR title since @MLnick is
addressing that API separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
