Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r115409843
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -128,41 +130,52 @@ private[spark] class CompressedMapStatus(
      * @param numNonEmptyBlocks the number of non-empty blocks
      * @param emptyBlocks a bitmap tracking which blocks are empty
      * @param avgSize average size of the non-empty blocks
    + * @param hugeBlockSizesArray sizes of huge blocks by their reduceId.
      */
     private[spark] class HighlyCompressedMapStatus private (
         private[this] var loc: BlockManagerId,
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
    -    private[this] var avgSize: Long)
    +    private[this] var avgSize: Long,
    +    private[this] var hugeBlockSizesArray: Array[Tuple2[Int, Byte]])
    --- End diff --
    
    Why does hugeBlockSizesArray exist ? Is it for efficient serializable ?
    If yes, the then converting it into (Array[Int], Array[Byte]) would be 
better (with each array written directly - not as Tupe2 object) - more below 
though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to