Github user VinceShieh commented on a diff in the pull request:
https://github.com/apache/spark/pull/17894#discussion_r115415823
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1722,25 +1723,22 @@ private class LogisticAggregator(
var maxMargin = Double.NegativeInfinity
val margins = new Array[Double](numClasses)
+ val featureStdArray = new Array[Double](features.size)
--- End diff --
Agree. Still, we will try benchmark on the sparse dataset, if such change
hurt the performance for sparse data, we will bypass this change for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
