Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17916#discussion_r115625060
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala 
---
    @@ -19,26 +19,39 @@ package org.apache.spark.sql.sources
     
     import org.apache.spark.sql.{AnalysisException, SQLContext}
     import org.apache.spark.sql.test.SharedSQLContext
    -import org.apache.spark.sql.types.{StringType, StructField, StructType}
    +import org.apache.spark.sql.types._
     
     
     // please note that the META-INF/services had to be modified for the test 
directory for this to work
     class DDLSourceLoadSuite extends DataSourceTest with SharedSQLContext {
     
    -  test("data sources with the same name") {
    -    intercept[RuntimeException] {
    +  test("data sources with the same name - internal data sources") {
    +    val e = intercept[RuntimeException] {
           spark.read.format("Fluet da Bomb").load()
         }
    +    assert(e.getMessage.contains("Multiple sources found for Fluet da 
Bomb"))
    +  }
    +
    +  test("data sources with the same name - internal data source/external 
data source") {
    --- End diff --
    
    So, we will only allow this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to