Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17929#discussion_r115635851
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -53,3 +53,13 @@ set spark.sql.groupByAliases=false;
-- Check analysis exceptions
SELECT a AS k, COUNT(b) FROM testData GROUP BY k;
+
+-- turn on group by aliases (for remaining tests)
+set spark.sql.groupByAliases=true;
+
+-- Aggregate with empty input and non-empty GroupBy expressions.
+SELECT a, COUNT(1) FROM testData WHERE false GROUP BY a;
+
+-- Aggregate with empty input and empty GroupBy expressions.
+SELECT COUNT(1) FROM testData WHERE false;
--- End diff --
This test case would have passed before because it contains aggregate
expressions. The test case on the next line is the one which actually failed
because column pruning eliminates the aggregate expression, leaving us with an
Aggregate with no aggregate expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
