Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17948#discussion_r116152643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1003,18 +1003,31 @@ class Analyzer(
*/
object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] {
+ // This is a strict check though, we put this to apply the rule only
if the expression is not
+ // resolvable by child.
+ private def notResolvableByChild(attrName: String, child:
LogicalPlan): Boolean =
+ !child.output.exists(a => resolver(a.name, attrName))
--- End diff --
Nit: style
```Scala
private def notResolvableByChild(attrName: String, child: LogicalPlan):
Boolean = {
!child.output.exists(a => resolver(a.name, attrName))
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
