GitHub user gglanzani opened a pull request:
https://github.com/apache/spark/pull/17968
[SPARK-9792] Make DenseMatrix equality semantical
Before, you could have this code
```
A = SparseMatrix(2, 2, [0, 2, 3], [0], [2])
B = DenseMatrix(2, 2, [2, 0, 0, 0])
B == A # False
A == B # True
```
The second would be `True` as `SparseMatrix` already checks for semantic
equality. This commit changes `DenseMatrix` so that equality is
semantical as well.
## What changes were proposed in this pull request?
Better semantic equality for DenseMatrix
## How was this patch tested?
Unit tests were added, plus manual testing. Note that the code falls back
to the old behavior when `other` is not a SparseMatrix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gglanzani/spark SPARK-9792
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17968.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17968
----
commit 4c4d1c15eb4224444f9df703851c417881f9a464
Author: Giovanni Lanzani <giova...@lanzani.nl>
Date: 2017-05-12T20:15:04Z
[SPARK-9792] Make DenseMatrix equality semantical
Before, you could have this code
```
A = SparseMatrix(2, 2, [0, 2, 3], [0], [2])
B = DenseMatrix(2, 2, [2, 0, 0, 0])
B == A # False
A == B # True
```
The second would be `True` as `SparseMatrix` already checks for semantic
equality. This commit changes `DenseMatrix` so that equality is
semantical as well.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
