Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17933#discussion_r116377714
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ---
    @@ -98,6 +99,14 @@ object DateTimeUtils {
         sdf
       }
     
    +  private val threadLocalTimeZones = new ThreadLocal[mutable.Map[String, 
TimeZone]] {
    --- End diff --
    
    As we won't go to update this map. We only need synchronization when 
putting the values. The content of the map can be shared between threads when 
reading. I am wondering if we need a local map for each thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to