Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1980#discussion_r17992049
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -183,7 +185,8 @@ private[spark] object JettyUtils extends Logging {
     
         // Bind to the given port, or throw a java.net.BindException if the 
port is occupied
         def connect(currentPort: Int): (Server, Int) = {
    -      val server = new Server(new InetSocketAddress(hostName, currentPort))
    --- End diff --
    
    It looks like we used to bind Jetty to a specific hostname / interface, but 
it doesn't look like the new code uses `hostName` anywhere.  To preserve the 
same behavior, maybe we should call `connector.setHost()` after 
`connector.setPort()` in the code below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to