Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15628#discussion_r116603167
  
    --- Diff: 
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -148,7 +154,8 @@ sealed trait Matrix extends Serializable {
        *          and column indices respectively with the type `Int`, and the 
final parameter is the
        *          corresponding value in the matrix with type `Double`.
        */
    -  private[spark] def foreachActive(f: (Int, Int, Double) => Unit)
    +  @Since("2.2.0")
    +  def foreachActive(f: (Int, Int, Double) => Unit): Unit
    --- End diff --
    
    I think we should do the same for `foreachActive` in Vector which was 
already a public api long time ago.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to