Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17934#discussion_r116631097
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -146,7 +146,7 @@ object StringIndexer extends 
DefaultParamsReadable[StringIndexer] {
      * This is a temporary fix for the case when target labels do not exist 
during prediction.
      */
     @Since("1.4.0")
    -class StringIndexerModel (
    +class StringIndexerModel private[ml] (
    --- End diff --
    
    I thought this was made public on purpose.  StringIndexerModel is one case 
where it makes sense for users to create it manually (if they already have a 
list of the possible Strings).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to