Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17978
@felixcheung Thanks so much for the review. I addressed most of the
comments except auto generating code for defining `stringOrderType`. This
parameter is not a shared trait on the Scala side, and I thought only the
shared traits should be automatically generated. I have looked at the code for
other ML transformers, and many of them hard coded, for example,
[Imputer](https://github.com/apache/spark/blob/master/python/pyspark/ml/feature.py#L933)
and
[OneHotEncoder](https://github.com/apache/spark/blob/master/python/pyspark/ml/feature.py#L1520).
Please let me know if I'm wrong, and a reference to example would be
greatly appreciated.
Thanks much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
