Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17899#discussion_r116718934
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
 ---
    @@ -423,4 +423,25 @@ class DataFrameWindowFunctionsSuite extends QueryTest 
with SharedSQLContext {
           df.select(selectList: _*).where($"value" < 2),
           Seq(Row(3, "1", null, 3.0, 4.0, 3.0), Row(5, "1", false, 4.0, 5.0, 
5.0)))
       }
    +
    +  test("window functions in multiple selects") {
    --- End diff --
    
    Why this test? It does not really add anything new.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to