Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2379#discussion_r18001154
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
 ---
    @@ -18,12 +18,14 @@
     package org.apache.spark.deploy.history
     
     import org.apache.spark.SparkConf
    +import org.apache.spark.util.Utils
     
     /**
      * Command-line parser for the master.
      */
     private[spark] class HistoryServerArguments(conf: SparkConf, args: 
Array[String]) {
    -  private var logDir: String = null
    +  var logDir: String = null
    +  var propertiesFile: String = null
    --- End diff --
    
    I think these can be private


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to