Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r116883362
--- Diff:
core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
--- End diff --
@squito had the same concern. I purposefully leaked some memory at the end
of leakedPageMemoryIsDetected and got this very helpful trace:
[info] Test
org.apache.spark.memory.TaskMemoryManagerSuite.leakedPageMemoryIsDetected
started
[error] Test
org.apache.spark.memory.TaskMemoryManagerSuite.leakedPageMemoryIsDetected
failed: java.lang.AssertionError: expected:<0> but was:<4096>, took 0.007 sec
[error] at
org.apache.spark.memory.TaskMemoryManagerSuite.after(TaskMemoryManagerSuite.java:34)
[error] ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
