Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18008#discussion_r116883398
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -405,7 +404,7 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
updateAggregateMetrics(stageData, info.executorId, m, oldMetrics)
}
- val taskData = stageData.taskData.getOrElseUpdate(info.taskId,
TaskUIData(info, None))
--- End diff --
Important note here: in the old code, the `elseUpdate` branch would only be
taken in rare error cases where we somehow purged the TaskUIData which should
have been created when the task launched. It technically doesn't matter what we
put in for the `Option[Metrics]` here since it just gets unconditionally
overwritten on line 410 in the old code. So while my new code constructs
TaskUIData with default metrics it doesn't actually change the behavior of this
block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
