Github user JoshRosen commented on the issue:

    https://github.com/apache/spark/pull/17402
  
    I think that the scope / intent of the original SPARK-7200 JIRA was to 
include this type of logic as a generic assertion in multiple suites so that we 
gain additional implicit assertions in suites which would otherwise maybe not 
have them, whereas this patch looks mostly like cleanup/refactoring of a single 
suite's existing assertions.
    
    I don't have any objections to this patch but I don't see it as a big win 
either. I don't think that this PR's specific changes will actually help to 
prevent any bugs because we don't appear to be adding assertions which weren't 
already present in the existing code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to