Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17848#discussion_r116893118
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -85,8 +94,9 @@ case class UserDefinedFunction protected[sql] (
* @since 2.3.0
*/
def withName(name: String): this.type = {
- this._nameOption = Option(name)
- this
+ val udf = copyAll()
+ udf._nameOption = Option(name)
--- End diff --
I know your intention here (you probably mean we should not update values
even in `var` variables) though, is it okay that the code below has four times
object allocation in the worst case? I'm a bit worried about this point;
```
val udf = UserDefinedFunction(func, dataType,
inputTypes).withName(name).withNullability(nullable)
val withDeterminism = if (!deterministic) udf.nonDeterministic() else udf
val withDistinctLike = if (distinctLike) withDeterminism.withDistinctLike()
else withDeterminism
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
