Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2516#discussion_r18002724
--- Diff: core/src/main/scala/org/apache/spark/deploy/configConstants.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy
+
+/**
+ * Created by Dale on 19/09/2014.
+ * File is used to centralize references to configuration variables
+ */
+object ConfigConstants {
+ /**
+ * The name of your application. This will appear in the UI and in log
data.
+ */
+ val SparkAppName: String = "spark.app.name"
+
+ /**
+ * The main class to start executing
+ */
+ val SparkAppClass: String = "spark.app.class"
+
+ /**
+ * The cluster manager to connect to.
+ */
+ val SparkMaster: String = "spark.master"
+
+ /**
+ * Whether to launch the driver program locally ("client") or
+ * on one of the worker machines inside the cluster ("cluster")
+ */
+ val SparkDeployMode: String = "spark.deployMode"
+
+ /**
+ * Yarn client only: Number of executors to launch
+ */
+ val SparkExecutorInstances: String = "spark.executor.instances"
+
+ /**
+ * Spark standalone and Mesos only: Total cores for all executors.
+ */
+ val SparkCoresMax: String = "spark.cores.max"
+
+ /**
+ * Yarn client only: Number of cores per executor
+ */
+ val SparkExecutorCores: String = "spark.executor.cores"
+
+ /**
+ * Memory per executor
+ */
+ val SparkExecutorMemory: String = "spark.executor.memory"
+
+ /**
+ * Standalone cluster only: Memory for driver
+ */
+ val SparkDriverMemory: String = "spark.driver.memory"
+
+ /**
+ * Standalone cluster only: Number of cores for driver
+ */
+ val SparkDriverCores: String = "spark.driver.cores"
+
+ /**
+ * Extra class path entries to pass to the driver. Note that
+ * jars added with --jars are automatically included in the classpath.
+ */
+ val SparkDriverExtraClassPath: String = "spark.driver.extraClassPath"
+
+ /**
+ * Extra Java options to pass to the driver
+ */
+ val SparkDriverExtraJavaOptions: String = "spark.driver.extraJavaOptions"
+
+ /**
+ * Extra library path entries to pass to the driver.
+ */
+ val SparkDriverExtraLibraryPath: String = "spark.driver.extraLibraryPath"
+
+ /**
+ * Spark standalone with cluster deploy mode only:
+ * restart driver application on failure
+ */
+ val SparkDriverSupervise: String = "spark.driver.supervise"
+
+ /**
+ * The YARN queue to submit to
+ */
+ val SparkYarnQueue: String = "spark.yarn.queue"
+
+ /**
+ * Comma-separated list of files to be placed in the working directory
of each executor
+ */
+ val SparkFiles: String = "spark.files"
+
+ /**
+ * Comma-separated list of .zip, .egg, or .py files to place on the
PYTHONPATH for Python apps.
+ */
+ val SparkSubmitPyFiles = "spark.submit.pyFiles"
+
+ /**
+ * Yarn only: Comma separated list of archives to be extracted into the
+ * working directory of each executor
+ */
+ val SparkYarnDistArchives: String = "spark.yarn.dist.archives"
+
+ /**
+ * Comma-separated list of local jars to include on the driver and
executor classpaths.
+ */
+ val SparkJars: String = "spark.jars"
+
+ /**
+ * Should spark-submit run in verbose mode
+ */
+ val SparkVerbose: String = "spark.verbose"
+
+ /**
+ * Main application to run
+ */
+ val SparkAppPrimaryResource: String = "spark.app.primaryResource"
+
+ /**
+ * Arguments for application
+ */
+ val SparkAppArguments: String = "spark.app.arguments"
+
+ /**
+ * Location of the spark home directory
+ */
+ val SparkHome: String = "SPARK_HOME"
+
+ /**
+ * sub directory of SPARK_HOME that configuration is stored in
+ */
+ val SparkConfDir: String = "conf"
--- End diff --
Now it gets a little confusing. This is not a conf key, but a value.
All the constants are named similarly in this file, yet I see three
different things being defined here:
- conf keys
- environment variable names
- default values
Those three should be named differently so that it's easy to know what's
what.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
