Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18000#discussion_r117140137
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -166,7 +166,14 @@ private[parquet] object ParquetFilters {
        * Converts data sources filters to Parquet filter predicates.
        */
       def createFilter(schema: StructType, predicate: sources.Filter): 
Option[FilterPredicate] = {
    -    val dataTypeOf = getFieldMap(schema)
    +    val nameTypeMap = getFieldMap(schema)
    +
    +    // Parquet does not allow dots in the column name because dots are 
used as a column path
    --- End diff --
    
    Yes, it is. However, we don't already log pushed filters failed to create, 
e.g., `In` AFAIK. Probably, we should log in those cases across all the 
sources. If you don't strongly feel about this, I would like to not log here 
for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to