Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17997#discussion_r117153080
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -603,7 +603,13 @@ object DateTimeUtils {
*/
private[this] def getYearAndDayInYear(daysSince1970: SQLDate): (Int,
Int) = {
// add the difference (in days) between 1.1.1970 and the artificial
year 0 (-17999)
- val daysNormalized = daysSince1970 + toYearZero
+ var daysSince1970Tmp = daysSince1970
+ // In history,the period(5.10.1582 ~ 14.10.1582) is not exist
--- End diff --
It's only about comment, and I think 1582-10-5 or Oct. 5, 1582 is more
human readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
