Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18026#discussion_r117312841
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -163,16 +163,10 @@ trait StreamSinkProvider {
@InterfaceStability.Stable
trait CreatableRelationProvider {
/**
- * Save the DataFrame to the destination and return a relation with the
given parameters based on
- * the contents of the given DataFrame. The mode specifies the expected
behavior of createRelation
- * when data already exists.
- * Right now, there are three modes, Append, Overwrite, and
ErrorIfExists.
- * Append mode means that when saving a DataFrame to a data source, if
data already exists,
- * contents of the DataFrame are expected to be appended to existing
data.
- * Overwrite mode means that when saving a DataFrame to a data source,
if data already exists,
- * existing data is expected to be overwritten by the contents of the
DataFrame.
- * ErrorIfExists mode means that when saving a DataFrame to a data
source,
- * if data already exists, an exception is expected to be thrown.
+ * Saves a DataFrame to a destination (using data source-specific
parameters)
+ *
+ * @param mode specifies what happens when the destination already exists
+ * @param parameters data source-specific parameters
--- End diff --
Could you add the descriptions for the other two parameters here? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
