Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117250411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii(child: Expression) extends
UnaryExpression with ImplicitCastInp
}
/**
+ * Returns the ASCII character having the binary equivalent to n.
+ * If n is larger than 256 the result is equivalent to chr(n % 256)
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(expr) - Returns the ASCII character having the binary
equivalent to `expr`. If n is larger than 256 the result is equivalent to chr(n
% 256)",
+ extended = """
+ Examples:
+ > SELECT _FUNC_(65);
+ A
+ """)
+// scalastyle:on line.size.limit
+case class Chr(child: Expression) extends UnaryExpression with
ImplicitCastInputTypes {
+
+ override def dataType: DataType = StringType
+ override def inputTypes: Seq[DataType] = Seq(LongType)
+
+ protected override def nullSafeEval(value: Any): Any = {
+ val longVal = value.asInstanceOf[Long]
+ val shortVal = if (longVal > 255) (longVal % 256).toShort else
longVal.toShort
+ val stringVal = if (shortVal == 0) {
+ String.valueOf('\u0000')
+ } else if (shortVal < 0) {
+ ""
+ } else {
+ shortVal.toChar.toString
+ }
+ UTF8String.fromString(stringVal)
+ }
+
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
--- End diff --
I am 100% this is not being tested. Can you check how other expression test
the code they generate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
