Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18016#discussion_r117397093
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala ---
@@ -173,6 +173,14 @@ class MathFunctionsSuite extends QueryTest with
SharedSQLContext {
checkAnswer(
sql("SELECT ceiling(0), ceiling(1), ceiling(1.5)"),
Row(0L, 1L, 2L))
+
+ checkAnswer(
+ sql("SELECT ceil(1234567890123456), ceil(12345678901234567)"),
+ Row(1234567890123456L, 12345678901234567L))
+
+ checkAnswer(
+ sql("SELECT ceiling(1234567890123456), ceiling(12345678901234567)"),
+ Row(1234567890123456L, 12345678901234567L))
--- End diff --
ok, add new tests to the end of operators.sql.
please review it again.
thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
