Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17723#discussion_r117553643
--- Diff:
core/src/test/scala/org/apache/spark/deploy/security/ConfigurableCredentialManagerSuite.scala
---
@@ -64,36 +57,22 @@ class ConfigurableCredentialManagerSuite extends
SparkFunSuite with Matchers wit
test("using deprecated configurations") {
sparkConf.set("spark.yarn.security.tokens.hadoopfs.enabled", "false")
- sparkConf.set("spark.yarn.security.tokens.hive.enabled", "false")
+ sparkConf.set("spark.yarn.security.credentials.hive.enabled", "false")
credentialManager = new ConfigurableCredentialManager(sparkConf,
hadoopConf)
credentialManager.getServiceCredentialProvider("hadoopfs") should be
(None)
credentialManager.getServiceCredentialProvider("hive") should be (None)
- credentialManager.getServiceCredentialProvider("test") should not be
(None)
credentialManager.getServiceCredentialProvider("hbase") should not be
(None)
}
- test("verify obtaining credentials from provider") {
+ test("verify no credentials are obtained") {
credentialManager = new ConfigurableCredentialManager(sparkConf,
hadoopConf)
val creds = new Credentials()
- // Tokens can only be obtained from TestTokenProvider, for hdfs, hbase
and hive tokens cannot
- // be obtained.
+ // Tokens cannot be obtained from HDFS, Hive, HBase in unit tests.
credentialManager.obtainCredentials(hadoopConf, creds)
val tokens = creds.getAllTokens
- tokens.size() should be (1)
- tokens.iterator().next().getService should be (new Text("test"))
- }
-
- test("verify getting credential renewal info") {
--- End diff --
What is the reason that this test case is removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
