Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18023#discussion_r117586747
  
    --- Diff: 
sql/core/src/test/resources/sql-tests/inputs/query_regex_column.sql ---
    @@ -0,0 +1,24 @@
    +CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES
    +(1, "1"), (2, "2"), (3, "3"), (4, "4"), (5, "5"), (6, "6")
    +AS testData(key, value);
    +
    +CREATE OR REPLACE TEMPORARY VIEW testData2 AS SELECT * FROM VALUES
    +(1, 1), (1, 2), (2, 1), (2, 2), (3, 1), (3, 2)
    +AS testData2(a, b);
    --- End diff --
    
    Since the test cases are testing the regex pattern matching in column 
names, could you add more names and let the regex pattern match more columns?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to