Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r117602096
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -385,6 +385,7 @@ setGeneric("value", function(bcast) { 
standardGeneric("value") })
     #' @return A SparkDataFrame.
     #' @rdname summarize
     #' @export
    +#' @noRd
    --- End diff --
    
    hmm, I think some of the problems are orthogonal - for example, to avoid a 
`avg.rd` file we could just change `avg` in generic.R to have `@rdname 
column_aggregate_functions`?
    
    I feel the standard is to have documentation on the generic (and have it on 
the same rd) like 
https://stat.ethz.ch/R-manual/R-devel/library/base/html/mean.html



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to