GitHub user NewBoLing opened a pull request:
https://github.com/apache/spark/pull/18045
Update SVDPlusPlus.scala
I think updated information of updateY incorrectly send to source vertice.
the original code like the below.
ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) *
conf.gamma1))
In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).
we have already updated the part of y in usr._2 through sending the
message to destination vertex, and this method will effect the part of y in
usr._2,
but the part of pu is never updated. so we should send updateP to
source vertex not updateY.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NewBoLing/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18045
----
commit 3c28883c55cc977d68d504805973877d3ea02e54
Author: NewBoLing <[email protected]>
Date: 2017-05-20T11:39:27Z
Update SVDPlusPlus.scala
I think updated information of updateY incorrectly send to source vertice.
the original code like the below.
ctx.sendToSrc((updateP, updateY, (err - conf.gamma6 * usr._3) *
conf.gamma1))
In fact, usr._2 store pu + |N(u)|^(-0.5)*sum(y).
we have already updated the part of y in usr._2 through sending the
message to destination vertex, and this method will effect the part of y in
usr._2,
but the part of pu is never updated. so we should send updateP to
source vertex not updateY.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
