Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17770#discussion_r117687634
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -1741,7 +1743,8 @@ class Dataset[T] private[sql](
       def union(other: Dataset[T]): Dataset[T] = withSetOperator {
         // This breaks caching, but it's usually ok because it addresses a 
very specific use case:
         // using union to union many files or partitions.
    -    CombineUnions(Union(logicalPlan, other.logicalPlan))
    +    CombineUnions(Union(EliminateBarriers(logicalPlan), 
EliminateBarriers(other.logicalPlan)))
    +      .mapChildren(AnalysisBarrier)
    --- End diff --
    
    This looks a bit ugly. But the barrier will prevent `CombineUnions` work 
normally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to