Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18019#discussion_r117835357
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ---
    @@ -1268,6 +1268,51 @@ case class Ascii(child: Expression) extends 
UnaryExpression with ImplicitCastInp
     }
     
     /**
    + * Returns the ASCII character having the binary equivalent to n.
    + * If n is larger than 256 the result is equivalent to chr(n % 256)
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(expr) - Returns the ASCII character having the binary 
equivalent to `expr`. If n is larger than 256 the result is equivalent to chr(n 
% 256)",
    --- End diff --
    
    Also add one more point here. `Invalid code points are not validated.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to