Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17723#discussion_r117843431
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNHadoopAccessManager.scala
 ---
    @@ -100,21 +81,4 @@ private[security] class HadoopFSCredentialProvider
         }
       }
     
    -  private def getTokenRenewer(conf: Configuration): String = {
    -    val delegTokenRenewer = Master.getMasterPrincipal(conf)
    -    logDebug("delegation token renewer is: " + delegTokenRenewer)
    -    if (delegTokenRenewer == null || delegTokenRenewer.length() == 0) {
    -      val errorMessage = "Can't get Master Kerberos principal for use as 
renewer"
    -      logError(errorMessage)
    -      throw new SparkException(errorMessage)
    -    }
    -
    -    delegTokenRenewer
    -  }
    -
    -  private def hadoopFSsToAccess(hadoopConf: Configuration, sparkConf: 
SparkConf): Set[Path] = {
    -    sparkConf.get(FILESYSTEMS_TO_ACCESS).map(new Path(_)).toSet +
    -      sparkConf.get(STAGING_DIR).map(new Path(_))
    -        .getOrElse(FileSystem.get(hadoopConf).getHomeDirectory)
    --- End diff --
    
    @vanzin I'm refactoring this code, and trying to understand this part.  Why 
would STAGING_DIR override the default hadoop file system?  I would think you 
would want to fetch a delegation token for the default hadoop file system 
regardless, and then if STAGING_DIR is set, you'd want to fetch that one as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to