Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/17891#discussion_r118175057
--- Diff: python/pyspark/ml/tests.py ---
@@ -807,6 +807,18 @@ def test_logistic_regression(self):
except OSError:
pass
+ def logistic_regression_check_thresholds(self):
+ self.assertIsInstance(
+ LogisticRegression(threshold=0.5, thresholds=[0.5, 0.5]),
+ LogisticRegressionModel
--- End diff --
@zero323 @yanboliang Am I missing something? Why should the
LogisticRegression constructor return an instance of type
LogisticRegressionModel? Should you have to call fit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
