Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18073#discussion_r118195655
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -479,7 +479,8 @@ object ParquetFileFormat extends Logging {
partFiles: Seq[FileStatus],
ignoreCorruptFiles: Boolean): Seq[Footer] = {
val parFiles = partFiles.par
- parFiles.tasksupport = new ForkJoinTaskSupport(new ForkJoinPool(8))
+ val pool = new ForkJoinPool(8)
--- End diff --
The main concern is that if we share a thread pool for parquet reading, we
may limit the concurrency as @srowen pointed out in the JIRA.
If we have multiple parquet reading in parallel, they will share the pool.
Currently they own their pool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
