Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18068#discussion_r118231105
--- Diff: python/pyspark/ml/tests.py ---
@@ -1075,7 +1076,8 @@ def test_linear_regression_summary(self):
pValues = s.pValues
self.assertTrue(isinstance(pValues, list) and
isinstance(pValues[0], float))
# test evaluation (with training dataset) produces a summary with
same values
- # one check is enough to verify a summary is returned, Scala
version runs full test
+ # one check is enough to verify a summary is returned
+ # The child class LinearRegressionTrainingSummary runs full test
--- End diff --
@MLnick This is because the type of ```LinearRegressionModel.summary``` is
```LinearRegressionTrainingSummary```, but the return type of
```LinearRegressionModel.evalute()``` is ```LinearRegressionSummary```.
Theoretically we should test both, but we can simplify the test for only check
one function since we have checked all functions in the child class. Thanks for
@mpjlu to update this comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
