Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118263506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -792,7 +887,18 @@ class CodegenContext {
addMutableState(javaType(expr.dataType), value,
s"$value = ${defaultValue(expr.dataType)};")
- subexprFunctions += s"$fnName($INPUT_ROW);"
+ // Generate the code for this expression tree and wrap it in a
function.
--- End diff --
In the original pull-request, since `addMutableState` returned values that
were going to be referenced in `fn`, I had to declare the mutable state
accessors before the code. It's less important here. The really important part
for this pull-request is that the return value of `addNewFunction(fnName, fn)`
is given added to `subexprFunctions`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
