Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12414#discussion_r118307768
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala 
---
    @@ -163,12 +163,20 @@ class RFormula @Since("1.5.0") (@Since("1.5.0") 
override val uid: String)
         }.toMap
     
         // Then we handle one-hot encoding and interactions between terms.
    +    var hasReferenceCategory = false
    --- End diff --
    
    because then the 2nd condition `!hasReferenceCategory` is always true on 
L175 
https://github.com/apache/spark/pull/12414/files#diff-bedaa993ebc2cc2e0d496859095270feR175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to