Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
> it's really hard to review the tests... Can we just add some simple tests
and refactor the test suites in a follow-up PR?
It's a big, complicated diff, and I sympathize. Basically, I started adding
support for testing this new functionality across Hive versions and saw how
much code duplication there was with the existing `VersionsSuite.scala`. And I
didn't want to just jam all the new tests into `VersionsSuite.scala`. The new
tests really are rather specialized and belong in their own test suite. So I
refactored as I described in my (updated) PR description to create something
that reduced code duplication and laid the foundation for additional,
specialized, cross-Hive-version tests.
I think as a compromise we might leave the existing `VersionsSuite.scala`
code alone, acknowledge the code duplication with the new test code and follow
up with a complete refactoring. I think that would simplify the review of the
new tests without sacrificing test coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
