Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18084#discussion_r118376642
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -796,9 +796,12 @@ private[deploy] class Master(
}
private def relaunchDriver(driver: DriverInfo) {
- driver.worker = None
- driver.state = DriverState.RELAUNCHING
- waitingDrivers += driver
+ removeDriver(driver.id, DriverState.RELAUNCHING, None)
+ val newDriver = createDriver(driver.desc)
--- End diff --
Do you have a good reason to remove and create the driver in this case? It
looks like some kind of overkill compared to the old logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
