Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18073#discussion_r118382694
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -495,6 +496,8 @@ object ParquetFileFormat extends Logging {
} else {
throw new IOException(s"Could not read footer for file:
$currentFile", e)
}
+ } finally {
+ pool.shutdown()
--- End diff --
@zsxwing @gatorsmile
I was shutdowning it outside at the beginning of this PR. I changed to
current way after @srowen's suggestion.
I was thinking it can be wrong initially. But seems it is fine and I think
the tasks are all invoked at the beginning and no more tasks are submitted
later, so to shutdown inside is ok.
I can go to submit a follow-up if you still think we need to change it.
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
