Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18064#discussion_r118391216
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
---
@@ -161,50 +161,50 @@ object FileFormatWriter extends Logging {
}
}
- SQLExecution.withNewExecutionId(sparkSession, queryExecution) {
- // This call shouldn't be put into the `try` block below because it
only initializes and
- // prepares the job, any exception thrown from here shouldn't cause
abortJob() to be called.
- committer.setupJob(job)
-
- try {
- val rdd = if (orderingMatched) {
- queryExecution.toRdd
- } else {
- SortExec(
- requiredOrdering.map(SortOrder(_, Ascending)),
- global = false,
- child = queryExecution.executedPlan).execute()
- }
- val ret = new Array[WriteTaskResult](rdd.partitions.length)
- sparkSession.sparkContext.runJob(
- rdd,
- (taskContext: TaskContext, iter: Iterator[InternalRow]) => {
- executeTask(
- description = description,
- sparkStageId = taskContext.stageId(),
- sparkPartitionId = taskContext.partitionId(),
- sparkAttemptNumber = taskContext.attemptNumber(),
- committer,
- iterator = iter)
- },
- 0 until rdd.partitions.length,
- (index, res: WriteTaskResult) => {
- committer.onTaskCommit(res.commitMsg)
- ret(index) = res
- })
-
- val commitMsgs = ret.map(_.commitMsg)
- val updatedPartitions = ret.flatMap(_.updatedPartitions)
- .distinct.map(PartitioningUtils.parsePathFragment)
-
- committer.commitJob(job, commitMsgs)
- logInfo(s"Job ${job.getJobID} committed.")
- refreshFunction(updatedPartitions)
- } catch { case cause: Throwable =>
- logError(s"Aborting job ${job.getJobID}.", cause)
- committer.abortJob(job)
- throw new SparkException("Job aborted.", cause)
+ // TODO: make sure there is execution id when we reach here.
--- End diff --
Is there any case that execution id is missing? Otherwise, we can just add
an assertion here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
