Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17343#discussion_r118429093
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java ---
@@ -339,23 +355,26 @@ void forceSorterToSpill() throws IOException {
assert (spills.length >= 2);
final int numPartitions = partitioner.numPartitions();
final long[] partitionLengths = new long[numPartitions];
- final InputStream[] spillInputStreams = new
FileInputStream[spills.length];
+ final InputStream[] spillInputStreams = new InputStream[spills.length];
+ final OutputStream bos = new BufferedOutputStream(
+ new FileOutputStream(outputFile),
+ (int)
sparkConf.getSizeAsKb("spark.shuffle.unsafe.file.output.buffer", "32k") * 1024);
// Use a counting output stream to avoid having to close the
underlying file and ask
// the file system for its size after each partition is written.
- final CountingOutputStream mergedFileOutputStream = new
CountingOutputStream(
- new FileOutputStream(outputFile));
+ final CountingOutputStream mergedFileOutputStream = new
CountingOutputStream(bos);
boolean threwException = true;
try {
for (int i = 0; i < spills.length; i++) {
- spillInputStreams[i] = new FileInputStream(spills[i].file);
+ spillInputStreams[i] = new
NioBufferedFileInputStream(spills[i].file,
+ (int) sparkConf.getSizeAsKb("spark.shuffle.file.buffer",
"32k") * 1024);
--- End diff --
nit: the formatting seems a bit off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
