Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18083#discussion_r118431897
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -226,3 +240,34 @@ private[spark] object LiveListenerBus {
val name = "SparkListenerBus"
}
+private[spark] class LiveListenerBusMetrics(queue: LinkedBlockingQueue[_])
extends Source {
+ override val sourceName: String = "LiveListenerBus"
+ override val metricRegistry: MetricRegistry = new MetricRegistry
+
+ /**
+ * The total number of events posted to the LiveListenerBus. This counts
the number of times
+ * that `post()` is called, which might be less than the total number of
events processed in
+ * case events are dropped.
--- End diff --
Yes. I was perhaps wasn't explicit enough in the comment, so I'll reword it
or just drop the second confusing half.
Is it clearer if I say
> This counts the number of times that `post()` has been called called, not
the total number of events that have completed processing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
