Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14269#discussion_r118432313
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -103,4 +103,9 @@ package object config {
         .stringConf
         .checkValues(Set("hive", "in-memory"))
         .createWithDefault("in-memory")
    +
    +  private[spark] val LISTENER_BUS_EVENT_QUEUE_SIZE =
    +    ConfigBuilder("spark.scheduler.listenerbus.eventqueue.size")
    --- End diff --
    
    Another post-hoc review/complaint: I think that `size` might be misleading 
in this context where we're talking about a queue, since the size of a queue 
refers to the number of elements currently in the queue while its capacity 
refers to the maximum size that the queue can reach. This configuration name 
caused confusion in 
https://github.com/apache/spark/pull/18083/files/378206efb9f5c9628a678ba7defb536252f5cbcb#r118413115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to