Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18107#discussion_r118465966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
---
@@ -47,31 +60,25 @@ trait StateStore {
/** Version of the data in this store before committing updates. */
def version: Long
- /** Get the current value of a key. */
- def get(key: UnsafeRow): Option[UnsafeRow]
-
/**
- * Return an iterator of key-value pairs that satisfy a certain
condition.
- * Note that the iterator must be fail-safe towards modification to the
store, that is,
- * it must be based on the snapshot of store the time of this call, and
any change made to the
- * store while iterating through iterator should not cause the iterator
to fail or have
- * any affect on the values in the iterator.
+ * Get the current value of a key.
*/
- def filter(condition: (UnsafeRow, UnsafeRow) => Boolean):
Iterator[(UnsafeRow, UnsafeRow)]
-
- /** Put a new value for a key. */
- def put(key: UnsafeRow, value: UnsafeRow): Unit
+ def get(key: UnsafeRow): UnsafeRow
/**
- * Remove keys that match the following condition.
+ * Put a new value for a key.
+ * @return Previous value of the key or null.
*/
- def remove(condition: UnsafeRow => Boolean): Unit
+ def put(key: UnsafeRow, value: UnsafeRow): Unit
/**
* Remove a single key.
+ * @return Previous value of the removed key or null.
*/
def remove(key: UnsafeRow): Unit
+ def getRange(start: Option[UnsafeRow], end: Option[UnsafeRow]):
Iterator[UnsafeRowTuple]
--- End diff --
add docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
