Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11746#discussion_r118544204
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
    @@ -53,9 +53,11 @@ private[deploy] class DriverRunner(
       @volatile private var killed = false
     
       // Populated once finished
    -  private[worker] var finalState: Option[DriverState] = None
    -  private[worker] var finalException: Option[Exception] = None
    -  private var finalExitCode: Option[Int] = None
    +  @volatile private[worker] var finalState: Option[DriverState] = None
    +  @volatile private[worker] var finalException: Option[Exception] = None
    +
    +  // Timeout to wait for when trying to terminate a driver.
    +  private val DRIVER_TERMINATE_TIMEOUT_MS = 10 * 1000
    --- End diff --
    
    @cloud-fan Make sense. However, it requires designing an approach to set 
configurations for launching driver JVM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to