Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/18070#discussion_r118628471
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -338,6 +340,9 @@ private[spark] class Executor(
metricsSystem = env.metricsSystem)
threwException = false
res
+ } catch {
+ case _: CommitDeniedException =>
+ throw new TaskKilledException("commit denied")
--- End diff --
Doesn't a stage abort also cause tasks to show up as killed (due to "stage
cancelled"?)
https://github.com/apache/spark/blob/95aef660b73ec931e746d1ec8ae7848762ba0d7c/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1531
It seems to me that CommitDenied always implies the task is killed, in
which case it might be fine to convert all CommitDeniedExceptions into
TaskKilled.
Btw, there's a catch block below -- `case CausedBy(cDE:
CommitDeniedException) =>` which seems like the right place to be doing this
handling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
