Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/789#discussion_r18051738
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -81,21 +80,20 @@ class KryoSerializer(conf: SparkConf)
         kryo.register(classOf[HttpBroadcast[_]], new KryoJavaSerializer())
     
         // Allow the user to register their own classes by setting 
spark.kryo.registrator
    -    for (regCls <- registrator) {
    -      logDebug("Running user registrator: " + regCls)
    -      try {
    -        val reg = Class.forName(regCls, true, classLoader).newInstance()
    -          .asInstanceOf[KryoRegistrator]
    -
    -        // Use the default classloader when calling the user registrator.
    -        Thread.currentThread.setContextClassLoader(classLoader)
    -        reg.registerClasses(kryo)
    -      } catch {
    -        case e: Exception =>
    -          throw new SparkException(s"Failed to invoke $regCls", e)
    -      } finally {
    -        Thread.currentThread.setContextClassLoader(oldClassLoader)
    -      }
    +    try {
    +      val reg = conf.getOption("spark.kryo.registrator").map(
    +        Class.forName(_, true, 
classLoader).newInstance().asInstanceOf[KryoRegistrator]).getOrElse(
    +        new DefaultKryoRegistrator(conf))
    --- End diff --
    
    Can you use this style
    ```
    val reg = conf.getOption(...)
      .map(...)
      .getOrElse(...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to