Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18117#discussion_r118731891
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -214,11 +214,12 @@ final class ShuffleBlockFetcherIterator(
}
}
- // Shuffle remote blocks to disk when the request is too large.
- // TODO: Encryption and compression should be considered.
+ // Fetch remote shuffle blocks to disk when the request is too large.
Since the shuffle data is
+ // already encrypted and compressed over the wire(w.r.t. the related
configs), we can just fetch
+ // the data and write it to file directly.
--- End diff --
I think this change is really good. Sorry for my ambiguous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
