GitHub user setjet opened a pull request:
https://github.com/apache/spark/pull/18125
[SPARK-20891][SQL] Reduce duplicate code typedaggregators.scala
## What changes were proposed in this pull request?
The aggregators in typedaggregators.scala were polluted with duplicate
code, which only different in type. I have extracted the duplicate code in a
parent class, and have allowed the child classes to specify the type.
## How was this patch tested?
unit tests are already in place in DatasetAggregatorSuite.scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/setjet/spark spark-20891
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18125
----
commit 2e6899fac07926584dc745a27743884db1f48a8a
Author: setjet <rubenljans...@gmail.com>
Date: 2017-05-26T20:37:29Z
reduced duplicate code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
