Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r118811306 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2616,4 +2617,66 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext { val e = intercept[AnalysisException](sql("SELECT nvl(1, 2, 3)")) assert(e.message.contains("Invalid number of arguments")) } + + test("TRIM function-BOTH") { + val ae1 = intercept[ParseException]{ + sql("select lower(BOTH 'S' FROM 'SS abc S')").head --- End diff -- ltrim/rtrim can't using these options, right? We can use them as negative test for function names, and use trim for negative tests for option names.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org